Reduce response payload size for scenarios tab #7354
+76
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elmacioro
force-pushed
the
reduce-response-for-services-tab
branch
from
7befc41 to
34b783b
Compare
Elmacioro
force-pushed
the
reduce-response-for-services-tab
branch
3 times, most recently
from
23934d7 to
40e2e7e
Compare
|
created: #7365 |
Elmacioro
force-pushed
the
reduce-response-for-services-tab
branch
from
40e2e7e to
159a014
Compare
lciolecki
reviewed
Dec 23, 2024
| @@ -55,6 +57,25 @@ object ScenarioWithDetailsConversions { | |||
| ) | |||
| } | |||
|
|
|||
| def skipAdditionalFields(details: ScenarioWithDetails, skipOptions: SkipAdditionalFields): ScenarioWithDetails = { | |||
There was a problem hiding this comment.
I would rather prefer do not fetch this data from the DB at all. On the other hand I'm not sure is it now possible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Currently when we enter scenarios tab we fetch a lot of data regarding them. Some of the data isn't used at that level. It only bloats the response payload slowing down loading the tab.
In our Nussknacker instance we have a lot of scenarios so response payloads for that tab can reach around 7.6 MB. The biggest unused attribute that is sent along with the scenarios' details is
buildInfoby removing it and a few other optional fields not needed at that level we can lower the size of response by over 1 MB. Which can help us a bit with long load times of scenarios tab.Checklist before merge